Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Invalid payload attributes error code #6582

Merged
merged 14 commits into from
Feb 22, 2024
Merged

Use Invalid payload attributes error code #6582

merged 14 commits into from
Feb 22, 2024

Conversation

macfarla
Copy link
Contributor

Return "invalid payload attributes" instead of "invalid params" if the payload attributes are, in fact, invalid

fixes #6554

@macfarla
invalid payload error code
69305c6 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
invalid payload error code
19e9e28 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into invalid-paylo…
b8da609 
…ad-attributes
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

@macfarla macfarla requested a review from jflo February 16, 2024 07:31
@macfarla
Copy link
Contributor Author

@jflo I did not yet get a chance to verify this fixes those hive tests

@macfarla
Merge branch 'main' of github.com:hyperledger/besu into invalid-paylo…
cdd3f01 
…ad-attributes
@macfarla
invalid payload attributes error
b9ed5fa 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
invalid payload attributes error
65c2893 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
use non-zero timestamp
a8b4528 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

all the "Invalid Payload" tests are now passing off this branch. Running the full engine-cancun suite locally now to verify no regressions.

@macfarla
Copy link
Contributor Author

macfarla commented Feb 20, 2024 •
edited
Loading

ok so this fixes 4 out of the 9 currently failing - so all the "Invalid PayloadAttributes" ones. Similar fix needed for the 3 failing "ForkchoiceUpdatedVX" ones at the top of this screenshot
Screenshot 2024-02-20 at 1 49 46 pm

Ran all the "Invalid PayloadAttributes" ones locally - 7 tests, 0 failures.

NFO[02-19|15:45:56] hiveproxy started                        container=1f873092ddff addr=172.17.0.2:8081
INFO[02-19|15:45:56] API: suite started                       suite=0 name=engine-cancun
INFO[02-19|15:45:56] API: test started                        suite=0 test=1 name="engine-cancun test loader"
INFO[02-19|15:45:56] API: test started                        suite=0 test=2 name="Invalid PayloadAttributes, Zero timestamp, Syncing=False (Cancun) (besu_pr-invalid-payload-atts-git)"
INFO[02-19|15:45:58] API: client besu_pr-invalid-payload-atts-git started suite=0 test=2 container=cad7627f
INFO[02-19|15:46:07] API: test ended                          suite=0 test=2 pass=true
INFO[02-19|15:46:07] API: test started                        suite=0 test=3 name="Invalid PayloadAttributes, Zero timestamp, Syncing=True (Cancun) (besu_pr-invalid-payload-atts-git)"
INFO[02-19|15:46:09] API: client besu_pr-invalid-payload-atts-git started suite=0 test=3 container=2246c4e9
INFO[02-19|15:46:18] API: test ended                          suite=0 test=3 pass=true
INFO[02-19|15:46:18] API: test started                        suite=0 test=4 name="Invalid PayloadAttributes, Parent timestamp, Syncing=False (Cancun) (besu_pr-invalid-payload-atts-git)"
INFO[02-19|15:46:19] API: client besu_pr-invalid-payload-atts-git started suite=0 test=4 container=64af5854
INFO[02-19|15:46:28] API: test ended                          suite=0 test=4 pass=true
INFO[02-19|15:46:28] API: test started                        suite=0 test=5 name="Invalid PayloadAttributes, Parent timestamp, Syncing=True (Cancun) (besu_pr-invalid-payload-atts-git)"
INFO[02-19|15:46:30] API: client besu_pr-invalid-payload-atts-git started suite=0 test=5 container=f97e4d0c
INFO[02-19|15:46:39] API: test ended                          suite=0 test=5 pass=true
INFO[02-19|15:46:39] API: test started                        suite=0 test=6 name="Invalid PayloadAttributes, Missing BeaconRoot, Syncing=False (Cancun) (besu_pr-invalid-payload-atts-git)"
INFO[02-19|15:46:41] API: client besu_pr-invalid-payload-atts-git started suite=0 test=6 container=6de55403
INFO[02-19|15:46:50] API: test ended                          suite=0 test=6 pass=true
INFO[02-19|15:46:50] API: test started                        suite=0 test=7 name="Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True (Cancun) (besu_pr-invalid-payload-atts-git)"
INFO[02-19|15:46:51] API: client besu_pr-invalid-payload-atts-git started suite=0 test=7 container=72ed84a0
INFO[02-19|15:47:00] API: test ended                          suite=0 test=7 pass=true
INFO[02-19|15:47:00] API: test ended                          suite=0 test=1 pass=true
INFO[02-19|15:47:00] API: suite ended                         suite=0
INFO[02-19|15:47:01] simulation ethereum/engine finished      suites=1 tests=7 failed=0

@macfarla macfarla marked this pull request as ready for review February 20, 2024 03:57
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into invalid-paylo…
7f357e7 
…ad-attributes
@macfarla
use invalidPayloadAttributes error for V2 if non-null beacon root pre…
1159f4b 
… cancun

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'invalid-payload-attributes' of github.com:macfarla/besu…
8b46dce 
… into invalid-payload-attributes
@macfarla
use invalidPayloadAttributes error for V2 if non-null beacon root pre…
11770be 
… cancun

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
invalid payload attributes error for fcuv2
9367a62 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into invalid-paylo…
8585a45 
…ad-attributes
@macfarla
Copy link
Contributor Author

ok ready for review for real this time - only 1 remaining hive test failing (was failing before) - "Invalid Missing Ancestor Syncing ReOrg, StateRoot, EmptyTxs=False, CanonicalReOrg=False, Invalid P9 (Cancun)"

pinges
pinges approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 094fbb9 into hyperledger:main Feb 22, 2024
55 of 63 checks passed
@macfarla
Copy link
Contributor Author

"Invalid Missing Ancestor Syncing ReOrg, StateRoot, EmptyTxs=False, CanonicalReOrg=False, Invalid P9 (Cancun)"

this test is actually passing when we look online - it just fails locally.

@macfarla macfarla deleted the invalid-payload-attributes branch February 27, 2024 05:21
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 28, 2024
@macfarla @suraneti
Use Invalid payload attributes error code (hyperledger#6582)
e9ae692 
* invalid payload error code

* use non-zero timestamp

* use invalidPayloadAttributes error for V2 if non-null beacon root pre cancun

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
Use Invalid payload attributes error code (hyperledger#6582)
81413c9 
* invalid payload error code

* use non-zero timestamp

* use invalidPayloadAttributes error for V2 if non-null beacon root pre cancun

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@macfarla @amsmota
Use Invalid payload attributes error code (hyperledger#6582)
bd56ef3 
* invalid payload error code

* use non-zero timestamp

* use invalidPayloadAttributes error for V2 if non-null beacon root pre cancun

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: amsmota <antonio.mota@citi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinges pinges pinges approved these changes

@jflo jflo Awaiting requested review from jflo

@Gabriel-Trintinalia Gabriel-Trintinalia Awaiting requested review from Gabriel-Trintinalia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining Hive Cancun Failures
2 participants
@macfarla @pinges